search

UnixJunkie / vector3

module for 3D vectors (implemented as a record of x, y and z floats)
6 stars 0 forks source link

improved error message for the function of_string #5

Closed fccm closed 11 years ago

fccm commented 11 years ago

improved error message for the function of_string, providing an Invalid_argument exception, with the module/function name and the message from the Scanf.Scan_failure exception which describes where the read error is.

UnixJunkie commented 11 years ago

I don't like the addition of a new function with the same name, I changed directly in the trunk. Also, catching only Scan_failure is too restrictive.

fccm commented 11 years ago

Why did you asked me by email to send it as a pull request then?

Why don't you just do your code to your taste?

UnixJunkie commented 11 years ago

because the code you sent me by e-mail was only a part of what you meant