search

UnkindPartition / tasty-golden

Golden test support for Tasty
MIT License
36 stars 15 forks source link

Use typed-process rather than process to launch diff #46

Closed jrp2014 closed 4 years ago

jrp2014 commented 4 years ago

Here, as a proof-of concept, is an alternative approach to launching diff, using typed-process.

This seems to avoid the Windows limitations (although I have left the comments in for now).

Both cabal test and the example seem to produce the right results.

UnkindPartition commented 4 years ago

For future reference, the context for this PR is here: https://github.com/feuerbach/tasty-golden/issues/44#issuecomment-650734377.

UnkindPartition commented 4 years ago

Thanks, this is now merged. So which of the comments can we now get rid of?

UnkindPartition commented 4 years ago

I updated the docs according to my understanding — please open a new PR if they need correction.