search

UnkindPartition / tasty

Modern and extensible testing framework for Haskell
640 stars 110 forks source link

Don't depend on unbounded-delays for riscv64 #371

Closed felixonmars closed 3 weeks ago

felixonmars commented 1 year ago

64-bit RISC-V should fall into the same case in https://github.com/UnkindPartition/tasty/pull/344 and should be added here. Tested locally.

Bodigrim commented 1 year ago 
$ cabal check
...
Warning: Unknown architecture name 'riscv64'
Warning: Hackage would reject this package.

@felixonmars you need to raise a Cabal PR first, adding a new architecture.

felixonmars commented 1 year ago

I actually thought I did... Now opened as https://github.com/haskell/cabal/pull/9062

Bodigrim commented 1 year ago

@amesgen @TerrorJack any ideas what's up with our WASM CI job?

amesgen commented 1 year ago

@amesgen @TerrorJack any ideas what's up with our WASM CI job?

Ah sorry, this is due to a bindist artifact expiration. I have an upstream MR to fix this properly in ghc-wasm-meta. This should be merged soon-ish; will create a PR as soon as it. To fix this immediately, one can bump https://github.com/UnkindPartition/tasty/blob/b509e0470fc27ba64a18c185611eee5ef805a7c7/.github/workflows/ci.yaml#L86 to bd9533e34df53694a4c7e4102fced1fdc0596024, do you want to do this here or shall I create a PR?

Bodigrim commented 1 year ago

It would be great if you raise a separate PR, thanks.

Bodigrim commented 7 months ago

Unfortunately, this would have to wait not only until Cabal 3.12 release itself (which is soon), but until Hackage upgrades to it.

Bodigrim commented 3 weeks ago

Thanks, we can finally merge this now!