Two IntMap-related improvements

Bodigrim commented 10 months ago

launchTestTree: use IntMap strict in values

At the moment we use Data.IntMap which is lazy in values, and we initialise values with thunks testStatus <$> testActions. This is outright silly: testStatus is just a selector for TVar field, forcing it to WHNF can do no harm.

We also take an opportunity to replace IntMap.fromList with IntMap.fromDistinctAscList.
statusMapResult: use IntSet instead of IntMap ()

It seems the only reason behind IntMap () was the absense of Data.IntMap.withoutKeys, which was only added in containers-0.5.8.

CC @martijnbastiaan for review

Bodigrim commented 10 months ago

@andreasabel good catch. I can put CPP of course, but I have no reason to keep compatibility with GHC < 8.6 (where 8.6 is only because of GHCJS). How do you feel about dropping earlier versions?

andreasabel commented 10 months ago

Thinking it over, I guess it is fine to go ahead with this PR as-is. Folks that insist on constraints: containers installed in their CI can drop GHC 8.0 from the testing phase there. For everyone else, this bump is not a problem.

VictorCMiraldo commented 10 months ago

FWIW, looks good to me too! :) Thank you for the improvements!

UnkindPartition / tasty

Two IntMap-related improvements #390