UnkindPartition / tasty

Modern and extensible testing framework for Haskell
637 stars 108 forks source link

Possibly unintended change in `tasty-1.5` #395

Closed andreasabel closed 8 months ago

andreasabel commented 9 months ago

Looking through the changes between 1.4.3 and 1.5 I noticed a strange commit: https://github.com/UnkindPartition/tasty/commit/8043c0cddc59e6ae389e2dfb52b20d0543b76a28 It is labelled "clean code" but it does change

when nonempty $ do printHeading :: IO (); getTraversal printBody

to

when nonempty $ printHeading
getTraversal printBody

A priori, this is not just a cleaning, but it is a semantic change, invoking getTraversal printBody now even when not nonempty. (I am getting heartbleed vibes here.)

Questions:

coot commented 9 months ago

I replied in the commit.

andreasabel commented 9 months ago

I assign you to this issue, if that is ok with you, @coot.

coot commented 9 months ago

That's perfectly fine.