when nonempty $ do printHeading :: IO (); getTraversal printBody
to
when nonempty $ printHeading
getTraversal printBody
A priori, this is not just a cleaning, but it is a semantic change, invoking getTraversal printBody now even when not nonempty. (I am getting heartbleed vibes here.)
Looking through the changes between 1.4.3 and 1.5 I noticed a strange commit: https://github.com/UnkindPartition/tasty/commit/8043c0cddc59e6ae389e2dfb52b20d0543b76a28 It is labelled "clean code" but it does change
to
A priori, this is not just a cleaning, but it is a semantic change, invoking
getTraversal printBody
now even whennot nonempty
. (I am getting heartbleed vibes here.)Questions: