UnkindPartition / tasty

Modern and extensible testing framework for Haskell
640 stars 110 forks source link

Avoid blanket import from `GHC.Conc` #398

Closed edsko closed 1 year ago

edsko commented 1 year ago

Corresponding ticket for async itself at https://github.com/simonmar/async/pull/153.

Bodigrim commented 1 year ago

@amesgen if you get a moment to fix WASM CI job, it would be most appreciated. (I assume it's just a hash change, but cannot verify AFK)

Bodigrim commented 1 year ago

@edsko could you please rebase?

Any particular motivation for this change? Why GHC.Conc only?

edsko commented 1 year ago

@Bodigrim Have rebased. As for motivation: GHC.Conc exports some stuff that Control.Concurrent.STM also exports, which leads to name clashes when using a version of stm that doesn't straight up re-export stuff from GHC.Conc but does something slightly different (such as specifically https://github.com/edsko/stm-debug).

Bodigrim commented 1 year ago

Thanks!