Unknown025 / Flans-Mod-Plus

Revision of Flan's Mod Plus for 1.7.10
Other
25 stars 19 forks source link

Canceling Reload On Switching Slots #135

Closed HighQualityCookie closed 7 months ago

HighQualityCookie commented 2 years ago

I had this idea with switching slots mid reload. Usually when you switch your slot while reloading, the reload keeps going until it is finished. I was wondering if it would be possible to somehow cancel the reload when the weapon is no longer being held. Especially when you reload weapons with long reload times, it would be really helpful. Sidearms would be more useful that way.

GoldSloth commented 2 years ago

This has been requested before - I think Breakdown does something similar?

It'd be a nice thing to have, but requires reload times being mapped to each gun rather than the player as a whole. It's quite a big piece of work imo. I doubt I'll be able to do it, unfortunately. It'd be appreciated if someone else could, though

pixelrider2000 commented 2 years ago

Yes, Breakdown has this feature. Sad to hear that it's so much effort. Wouldn't it be possible to get that code from Breakdown though, or doesn't that help very much?

User4240 commented 2 years ago

Yes, Breakdown has this feature. Sad to hear that it's so much effort. Wouldn't it be possible to get that code from Breakdown though, or doesn't that help very much?

That'd be nice though, it's pretty annoying when you accidentally reload a weapon with long reload time and you switch to other guns and can't shoot

GoldSloth commented 2 years ago

Thanks for your comments, we discussed it further in the Discord server and decided that there was another option:

What I was first thinking of was each weapon having its own seperate reload timer. That was the thing that was difficult to implement.

Second option is simply cancelling reload progress when slot is changed, so the reload progress is lost. That's much easier to implement, and would be in line with what you want, I think?

Does that all make sense?

pixelrider2000 commented 2 years ago

If the end result is the same (stopping the reload), then it sounds like a pretty great solution :)

APotatoGamerNoob commented 2 years ago

It sounds pretty good to me

Lightninge commented 2 years ago

Afaik the second option is the method Breakdown uses. So yeah would be so so dope if added to Ultimate!

GoldSloth commented 1 year ago

@TheWillyJ is trying to add this, I believe.

GoldSloth commented 1 year ago

Unfortunately Willy has kind of disappeared, so it's unlikely this will get worked on for a while. Someone else might be working on it though, so I'll follow that up.

GoldSloth commented 1 year ago

I think SwitchDelay adds something like this already, i kinda forgot it existed. SecretAgent implemented it a while back.

GoldSloth commented 7 months ago

Closing as this is probably resolved. Please reopen if needed.