Unknown025 / Flans-Mod-Plus

Revision of Flan's Mod Plus for 1.7.10
Other
25 stars 20 forks source link

Sound upon vehicle hit #166

Closed LavaHoleD closed 9 months ago

LavaHoleD commented 1 year ago

A new kind of sound: when a vehicle is hit, it will play a configurable sound/s defined in the vehicle config file and stored in the assets folder.

It could be done in three ways: 1. The simplest one: simply a new parameter which redirect to a sound. 2. The intermediate one: it will play an array of sounds (ex. vehicleHitSound sfx1, sfx2, sfx3). 3. The hard one: it will play a different sound depending on the damage value the vehicle has taken.

Edit: actually I just realized that there is a big difference between low caliber impact sounds and high caliber impact sounds. Perhaps it would have to be a bit more specific, maybe having a different sound based on the type of entity bullet that hit it.

Edit n2: yeah probably it would be a lot easier to add a parameter for ammo configs directly for vehicle hit sound.

It would be a small neat feature to improve realism

GoldSloth commented 1 year ago

There's already a hitmarker sound that plays for the shooter, but I agree a version that plays for the hit vehicle would make sense. It might be a bit tricky to get the config organised well, because of the different combinations of bullets and vehicles. Overall it's a low priority feature though so we're unlikely to get to it - I'll add it to the Trello board though.

Thanks for the suggestion:)

LavaHoleD commented 1 year ago

No problem and no worries! Keep up the good work!

GoldSloth commented 9 months ago

Tracked by https://github.com/Unknown025/Flans-Mod-Plus/issues/179

Please reopen or new issue if needed.