Unleash / helm-charts

Contains helm-charts for Unleash
Apache License 2.0
41 stars 56 forks source link

add support for secret csi provider #104

Closed yuvals41 closed 9 months ago

yuvals41 commented 10 months ago

Describe the feature request

hello,

i encountered an issue while deploying the helm chart and wanting to use secret store provider aws to safely deploy and use the secret in my aws secret manager https://github.com/aws/secrets-store-csi-driver-provider-aws

I encountered the issue while trying to use the volumes, but I don't see support for it on the values yaml..

i need to use the volume in the deployment yaml like this:

apiVersion: apps/v1
kind: Deployment
metadata:
  name: unleash-proxy
spec:
  template:
    spec:
      volumes:
        - name: secrets-store-inline
          csi:
            driver: secrets-store.csi.k8s.io
            readOnly: true
            volumeAttributes:
              secretProviderClass: "unleash-proxy-secret-provider"

Background

No response

Solution suggestions

i would suggest that i can use the values.yaml to change the volumes in the deployment template and maybe even add a secretStoreProvider template in the chart, these solution will clearly solve the issue

Thank you!

FredrikOseberg commented 9 months ago

@yuvals41

Hi,

Is still need on your side following this enhancement to edge charts?

yuvals41 commented 9 months ago

@yuvals41

Hi,

Is still need on your side following this enhancement to edge charts?

It's already taken care of, I created I pull request and they merge it

Thank you!

FredrikOseberg commented 9 months ago

Thanks! I'll close this then.