search

Unleash / helm-charts

Contains helm-charts for Unleash
Apache License 2.0
44 stars 56 forks source link

bug: don't set default "requests" in Unleash Edge chart values.yaml #122

Closed mbarczyk closed 9 months ago

mbarczyk commented 9 months ago

About the changes

Setting up default "requests" makes it impossible to omit certain portions of "requests" in local values.yaml file, e.g. not setting resources.limits.cpu is impossible. For more information see #121

Comment taken from Unleash template to be consistent: https://github.com/Unleash/helm-charts/blob/4cd3a4a2afec1a3048ccbafc2a7c869c64393ed4/charts/unleash/values.yaml#L193-L198

Closes #121

chriswk commented 9 months ago

So, the lint fail here is due to the chart version not being updated. We're currently at 2.2.2, so if you bump it to 2.2.3 we should be golden.

mbarczyk commented 9 months ago

@chriswk Done. Thank you for looking into it.

chriswk commented 9 months ago

Thank you. Merging :)