search

Unleash / helm-charts

Contains helm-charts for Unleash
Apache License 2.0
40 stars 54 forks source link

feat: generic extra manifests for unleash chart #124

Closed langesven closed 7 months ago

langesven commented 7 months ago

About the changes

This allows including resources like credentials for the database connection or the secret env vars for unleash (e.g. shared secret, google client secret, ...) from a 3rd-party secrets provider and then referencing those secrets in the "existing secrets"

This moves management of secrets relevant for the application into the charts values so people don't need to resort to managing them outside of the app or using a kustomization overlay to just add secrets from a 3rd party provider.

Pretty similar to the approach taken in https://github.com/Unleash/helm-charts/pull/111

Important files

Discussion points

chriswk commented 7 months ago

Hi @langesven . Thank you for this PR, I've taken the liberty to bring it up to date with the changes that happened to main earlier today. Once the checks are green I will merge. :)