search

Unleash / helm-charts

Contains helm-charts for Unleash
Apache License 2.0
40 stars 54 forks source link

feat: Support optional cloudsql-proxy sidecar #125

Closed brtkwr closed 7 months ago

brtkwr commented 7 months ago

About the changes

Closes #126

brtkwr commented 7 months ago

cc @chriswk @gastonfournier

iamdmitrij commented 7 months ago

Hi, I'm having deployment issues with new version 3.1.1 of this chart. I've traced back the problem to this PR in charts/unleash/templates/deployment.yaml#L67.

As far as I understand deployment of chart will fail if you use extra secrets in value file.

unleash:
  secrets:
    AUTH_TENANT_ID: test

Some logs:

Error: UPGRADE FAILED: template: unleash/charts/unleash/templates/deployment.yaml:67:27: executing "unleash/charts/unleash/templates/deployment.yaml" at <include "unleash.fullname" .>: error calling include: template: unleash/charts/unleash/templates/_helpers.tpl:14:14: executing "unleash.fullname" at <.Values.fullnameOverride>: can't evaluate field Values in type string
##[error]Error: UPGRADE FAILED: template: unleash/charts/unleash/templates/deployment.yaml:67:27: executing "unleash/charts/unleash/templates/deployment.yaml" at <include "unleash.fullname" .>: error calling include: template: unleash/charts/unleash/templates/_helpers.tpl:14:14: executing "unleash.fullname" at <.Values.fullnameOverride>: can't evaluate field Values in type string
brtkwr commented 7 months ago

This PR publishes version 3.1.0, not 3.0.11

iamdmitrij commented 7 months ago

Sorry, my bad. I'm using the newest version of this chart - 3.1.1.

brtkwr commented 7 months ago

Sorry about that, this should fix it: https://github.com/Unleash/helm-charts/pull/127/files