Unleash / helm-charts

Contains helm-charts for Unleash
Apache License 2.0
40 stars 54 forks source link

Correct Environment Variable in Helm Deployment Template #136

Closed linkinn closed 4 months ago

linkinn commented 4 months ago

Describe the bug

Within the Helm template used to deploy our application, there is an environment variable named DATABASE that is incorrectly configured. It should be DATABASE_NAME.

While investigating an issue with the application not functioning correctly when using a database name other than unleash, we identified the root cause to be the misconfiguration in the Helm deployment template. Within this template, the DATABASE environment variable is set to an incorrect value. This causes issues when the database name is different from unleash, as the application expects an environment variable named DATABASE_NAME.

Steps to reproduce the bug

1 - Deploy the application using the Helm template. 2 - Change the database name to something other than unleash. 3 - Notice that the application does not function correctly due to expecting an environment variable DATABASE_NAME instead of DATABASE.

Expected behavior

No response

Logs, error output, etc.

[2024-03-11T19:26:22.801] [ERROR] server-impl.js - Locking error: database "unleash" does not exist
[2024-03-11T19:26:22.803] [ERROR] server-impl.js - Failed to migrate db Error: Connection terminated unexpectedly
    at /unleash/node_modules/pg/lib/client.js:526:17
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async /unleash/node_modules/unleash-server/dist/lib/util/db-lock.js:30:9
    at async Object.start (/unleash/node_modules/unleash-server/dist/lib/server-impl.js:149:17)
node:internal/process/promises:288
            triggerUncaughtException(err, true /* fromPromise */);
            ^

Error: Connection terminated unexpectedly
    at /unleash/node_modules/pg/lib/client.js:526:17
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async /unleash/node_modules/unleash-server/dist/lib/util/db-lock.js:30:9
    at async Object.start (/unleash/node_modules/unleash-server/dist/lib/server-impl.js:149:17)

Screenshots

No response

Additional context

No response

Unleash version

No response

Subscription type

None

Hosting type

None

SDK information (language and version)

No response

chriswk commented 4 months ago

Hi @linkinn - You're absolutely correct, and we're sorry. I'll make a PR fixing this. Thank you for taking the time to file this bug.