search

Unleash / helm-charts

Contains helm-charts for Unleash
Apache License 2.0
44 stars 57 forks source link

Allow topologySpreadConstraints for unleash #158

Closed pvickery-ParamountCommerce closed 3 months ago

pvickery-ParamountCommerce commented 3 months ago

About the changes

Adds support for topologySpreadConstraints to the unleash chart. This was copied from the unleash-edge helm chart

chriswk commented 3 months ago

Hi @pvickery-ParamountCommerce - Thanks for your contribution. It's going to fail our checks, could I trouble you to bump the patch version inside Chart.yaml by one, so that I can merge and release this?

pvickery-ParamountCommerce commented 3 months ago

Hi!

Thanks so much for your contribution.

We need a patch bump inside Chart.yaml to successfully pass our tests; once that's in place I'll approve and merge this

Thanks! I've bumped the version and applied the change to unleash-proxy as well. I also reset and squashed my changes for a cleaner commit history

pvickery-ParamountCommerce commented 3 months ago

Hey @chriswk, could you give this a review when you have a sec? Thanks!

chriswk commented 3 months ago

again, thank you, sorry for the late response. This got away from me. Will merge today

pvickery-ParamountCommerce commented 3 months ago

again, thank you, sorry for the late response. This got away from me. Will merge today

Thanks Chris! and no worries :slightly_smiling_face: