search

Unleash / helm-charts

Contains helm-charts for Unleash
Apache License 2.0
44 stars 57 forks source link

Added autoscaling values to values.yaml #52

Closed chriswk closed 2 years ago

chriswk commented 2 years ago

To better document possible values for Autoscaling, and as a response to #50 this PR adds the possible autoscaling settings to values.yaml

fixes: #50

thomasheartman commented 2 years ago

@chriswk Is the failing lint check here worth listening to or should we ignore it?

Looking at the output, I'm not entirely sure what it wants us to do:

Linting chart 'unleash => (version: "2.7.0", path: "charts/unleash")'
Checking chart 'unleash => (version: "2.7.0", path: "charts/unleash")' for a version bump...
>>> git cat-file -e origin/main:charts/unleash/Chart.yaml
>>> git show origin/main:charts/unleash/Chart.yaml
Error: Error linting charts: Error processing charts
Old chart version: 2.7.0
New chart version: 2.7.0
------------------------------------------------------------------------------------------------------------------------
 ✖︎ unleash => (version: "2.7.0", path: "charts/unleash") > Chart version not ok. Needs a version bump!
------------------------------------------------------------------------------------------------------------------------

It says old and new versions are the same, but I haven't used the tool before, so maybe that's intentional? 🤔

thomasheartman commented 2 years ago

@chriswk Just bumping this so you don't forget about it 😄