search

Unleash / helm-charts

Contains helm-charts for Unleash
Apache License 2.0
41 stars 56 forks source link

Fix PostgreSQL secret name #70

Closed sturman closed 1 year ago

sturman commented 1 year ago

About the changes

Closes #69

Important files

Discussion points

thomasheartman commented 1 year ago

Thanks for the PR! It looks like it'll work and it might be a sensible solution. But it's not clear to me whether the error is in the deployment file or the secret file. That is: should it actually be postgresql-password and it's the secret that's wrong? Considering that the deployment chart has used postgresql-password for at least two years, I'm inclined to think that the secret manifest what should be updated.

Helm lord @chriswk, what's your take on this?

chriswk commented 1 year ago

This looks fair to me. Will approve and merge.