Change default values for Bitnami Postgres helm chart

[sturman]

About the changes

Bitnami PostgreSQL helm charts does not have postgresqlDatabase, postgresqlUsername and postgresqlPassword so the keys were changed.

Important files

Discussion points

[gastonfournier]

Hi @sturman I'm happy to look into this, but I'm not familiar with how to verify that this change is sound. Would you mind adding some manual test steps to the description of the PR (or link to the documentation if there's any), so I can validate the change? Thanks!

[promiseofcake]

This fails on a default install locally.

$ kubectl logs -f unleash-7778d47cc7-v2bxv                                                             1
[2023-03-10T17:57:32.537] [ERROR] server-impl.js - Failed to migrate db error: password authentication failed for user "unleash"
    at Parser.parseErrorMessage (/unleash/node_modules/pg-protocol/dist/parser.js:287:98)
    at Parser.handlePacket (/unleash/node_modules/pg-protocol/dist/parser.js:126:29)
    at Parser.parse (/unleash/node_modules/pg-protocol/dist/parser.js:39:38)
    at Socket.<anonymous> (/unleash/node_modules/pg-protocol/dist/index.js:11:42)
    at Socket.emit (node:events:513:28)
    at addChunk (node:internal/streams/readable:315:12)
    at readableAddChunk (node:internal/streams/readable:289:9)
    at Socket.Readable.push (node:internal/streams/readable:228:10)
    at TCP.onStreamRead (node:internal/stream_base_commons:190:23) {
  length: 103,
  severity: 'FATAL',
  code: '28P01',
  detail: undefined,
  hint: undefined,
  position: undefined,
  internalPosition: undefined,
  internalQuery: undefined,
  where: undefined,
  schema: undefined,
  table: undefined,
  column: undefined,
  dataType: undefined,
  constraint: undefined,
  file: 'auth.c',
  line: '326',
  routine: 'auth_failed'
}
[ERROR] error: password authentication failed for user "unleash"
    at Parser.parseErrorMessage (/unleash/node_modules/pg-protocol/dist/parser.js:287:98)
    at Parser.handlePacket (/unleash/node_modules/pg-protocol/dist/parser.js:126:29)
    at Parser.parse (/unleash/node_modules/pg-protocol/dist/parser.js:39:38)
    at Socket.<anonymous> (/unleash/node_modules/pg-protocol/dist/index.js:11:42)
    at Socket.emit (node:events:513:28)
    at addChunk (node:internal/streams/readable:315:12)
    at readableAddChunk (node:internal/streams/readable:289:9)
    at Socket.Readable.push (node:internal/streams/readable:228:10)
    at TCP.onStreamRead (node:internal/stream_base_commons:190:23)

But so did the previous version.

[sturman]

@promiseofcake helm install with default values works for me. Here is the terminal output.

minikube (unleash) ~/projects/contribute 
❯ k get pods
No resources found in unleash namespace.

minikube (unleash) ~/projects/contribute 
❯ helm search repo unleash
NAME                    CHART VERSION   APP VERSION     DESCRIPTION                                       
unleash/unleash         2.7.7           4.19.4          Unleash is a open source feature flag & toggle ...
unleash/unleash-proxy   0.2.2           v0.13.1         A Helm chart for Kubernetes                       

minikube (unleash) ~/projects/contribute 
❯ helm install unleash unleash/unleash --version 2.7.7
NAME: unleash
LAST DEPLOYED: Sat Mar 11 10:51:38 2023
NAMESPACE: unleash
STATUS: deployed
REVISION: 1
NOTES:
1. Get the application URL by running these commands:
  export POD_NAME=$(kubectl get pods --namespace unleash -l "app.kubernetes.io/name=unleash,app.kubernetes.io/instance=unleash" -o jsonpath="{.items[0].metadata.name}")
  export CONTAINER_PORT=$(kubectl get pod --namespace unleash $POD_NAME -o jsonpath="{.spec.containers[0].ports[0].containerPort}")
  echo "Visit http://127.0.0.1:8080 to use your application"
  kubectl --namespace unleash port-forward $POD_NAME 8080:$CONTAINER_PORT

minikube (unleash) ~/projects/contribute 
❯ k get pods -w
NAME                      READY   STATUS    RESTARTS   AGE
unleash-8cbdc6df6-kdw2z   0/1     Error     0          7s
unleash-postgresql-0      0/1     Running   0          7s
unleash-8cbdc6df6-kdw2z   0/1     Running   1          7s
unleash-8cbdc6df6-kdw2z   0/1     Error     1          9s
unleash-8cbdc6df6-kdw2z   0/1     CrashLoopBackOff   1          10s
unleash-postgresql-0      1/1     Running            0          15s
unleash-8cbdc6df6-kdw2z   0/1     Running            2          24s
unleash-8cbdc6df6-kdw2z   1/1     Running            2          100s