search

Unleash / helm-charts

Contains helm-charts for Unleash
Apache License 2.0
41 stars 56 forks source link

Update hpa.yaml use autoscaling/v2 #72

Closed yxxhero closed 1 year ago

yxxhero commented 1 year ago

https://kubernetes.io/docs/reference/using-api/deprecation-guide/#horizontalpodautoscaler-v126

About the changes

Closes #

Important files

Discussion points

yxxhero commented 1 year ago

https://kubernetes.io/releases/patch-releases/#non-active-branch-history

chriswk commented 1 year ago

Hi @yxxhero . thank you for this contribution. Could I ask you to please bump the Chart version so that our auto-tests actually work.

yxxhero commented 1 year ago

@chriswk 2.7.8? right? Thanks very much.

yxxhero commented 1 year ago

@chriswk fixed.

chriswk commented 1 year ago

Thank you. Running the linting now. I aim to have this merged today. Thank you again. :)

yxxhero commented 1 year ago

@chriswk all is ok. by the way. when will the new version be released? thanks very much.

yxxhero commented 1 year ago

@chriswk please rerun the ci jobs.

chriswk commented 1 year ago

I did this as part of getting all our charts to validate with kubeconform with hpa and ingresses activated, so will close this PR. Thank you for the timely reminder that we were using a deprecated version of the schema @yxxhero, it pushed me to do a bit of overdue maintenance on our build process.