search

Unleash / helm-charts

Contains helm-charts for Unleash
Apache License 2.0
41 stars 56 forks source link

Unleash-Proxy helm-chart Deployment template missing quotation mark closing #75

Closed fulcrum29 closed 1 year ago

fulcrum29 commented 1 year ago

Describe the bug

There is no quotation closing here, beacause of that UNLEASH_URL is always ended with quota sign, creating 403 error for unleash-proxy. https://github.com/Unleash/helm-charts/blob/unleash-proxy-0.3.0/charts/unleash-proxy/templates/deployment.yaml#L57

Steps to reproduce the bug

No response

Expected behavior

No response

Logs, error output, etc.

No response

Screenshots

No response

Additional context

No response

Unleash version

unleash-proxy helm chart 0.3.0

Subscription type

None

Hosting type

None

SDK information (language and version)

No response

alv91 commented 1 year ago

fix here https://github.com/Unleash/helm-charts/pull/74

daveleek commented 1 year ago

Thank you @fulcrum29 for letting us know, and @alv91 for the PR! We'll have a look!

chriswk commented 1 year ago

Fixed with PR #74