search

Unleash / helm-charts

Contains helm-charts for Unleash
Apache License 2.0
41 stars 56 forks source link

allow ssl configuration #95

Closed tylerbrewer2 closed 9 months ago

tylerbrewer2 commented 10 months ago

About the changes

SSL configuration is not able to be passed via environment variable in the helm chart. Any attempt to pass stringified JSON (docs) results in a Helm parsing error.

Semi related to #94

chriswk commented 10 months ago

Hi @tylerbrewer2 - Sorry for the late response. I even see we managed to get some other changes so your version is out of date, could I bother you to rebase on top of main, making sure to bump the chart version to one patch version new than what's currently on main. I'm inclined to accept this, it definitely looks to do what we want with stringifying and converting the yaml to json, but I want to make sure our CI linting and installing passes so I don't have to fix it on main after merging.

tylerbrewer2 commented 10 months ago

No problem! Should be good now

nunogois commented 9 months ago

I believe this fixes https://github.com/Unleash/helm-charts/issues/102

tylerbrewer2 commented 8 months ago

@chriswk Sorry for dropping the ball on this but glad to see it merged in!