thompson-tomo commented 5 months ago

Description

Adds a dotnet 6 target to allow for the removal of the Microsoft.CSharp reference for that framework and newer.

Fixes #201

Type of change

[x] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

How Has This Been Tested?

Simple compilation of project for new framework and ran unit tests

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

thompson-tomo commented 5 months ago

@daveleek is there anything outstanding from me for this MR?

daveleek commented 5 months ago

Thank you @thompson-tomo! No you've done your part here. We're just going to add a build and a build step for verifying this continues to work on .NET Framework (windows) in the future!

thompson-tomo commented 5 months ago

No worries @daveleek thanks for the update

Unleash / unleash-client-dotnet

#201 Added net6 target to remove dependency on Microsoft.CS… #204

Description

Type of change

How Has This Been Tested?

Checklist: