search

Unleash / unleash-client-go

Unleash client SDK for Go
https://docs.getunleash.io
Apache License 2.0
138 stars 55 forks source link

feat: return feature from isEnabled to avoid another lookup #167

Closed jameshartig closed 10 months ago

jameshartig commented 10 months ago

About the changes

Previously GetVariant would do 2 storage.Get calls which might be costly depending on the implementation. It doesn't need to do the second one if we just return the feature from isEnabled.

Closes #161

Important files

Discussion points

FredrikOseberg commented 10 months ago

About the changes

Previously GetVariant would do 2 storage.Get calls which might be costly depending on the implementation. It doesn't need to do the second one if we just return the feature from isEnabled.

Closes #161

Important files

Discussion points

I'll take a look at this as soon as I can