Unleash / unleash-client-java

Unleash client SDK for Java
https://docs.getunleash.io
Apache License 2.0
118 stars 69 forks source link

fix: change seed for variantutils to ensure fair distribution #220

Closed chriswk closed 10 months ago

chriswk commented 10 months ago

What

Uses a new seed for ensuring a fair distrbution for variants.

Background

After a customer reported that variant distribution seemed skewed we performed some testing and found that since we use the same hash string for both gradual rollout and variant allocation we'd reduced the set of groups we could get to whatever percentage our gradual rollout was set.

Example

Take a gradualRollout of 10%, this will select normalized hashes between 1 and 10, when we then again hash the same string that gave us between 1 and 10, but with modulo 1000 for variants, this will only give us 100 possible groups, instead of the expected 1000.

Fix

Force the normalization to accept a seed, and make sure to use a new seed when normalizing the variant distribution hash.

Worth noting

This will require release 9.0.0, since we're changing the signature of public methods.