search

Unleash / unleash-client-nextjs

Unleash SDK for Next.js
28 stars 9 forks source link

feat: flagsClient custom config #97

Closed Netail closed 2 days ago

Netail commented 1 week ago

About the changes

Allow passing of custom clientKey, appName & url into the flagsClient instead of relying on env variables

Important files

Discussion points

Netail commented 1 week ago

Might be good to add a pre-commit hook for prettier. When I ran prettier, it formatted 34 files

Netail commented 6 days ago

Very good addition. Would you like to also add should send metrics test, or some check that config is correct?

Added additional test regarding sending metrics

Tymek commented 2 days ago

This can now be tested in v1.6.0-beta.0 or just beta tag