search

Unleash / unleash-client-node

Unleash client SDK for Node.js
https://docs.getunleash.io
Apache License 2.0
210 stars 71 forks source link

Unleash client stops fetching #615

Closed olehfitsyk closed 3 months ago

olehfitsyk commented 3 months ago

Describe the bug

We encountered an issue with Unleash Proxy a few times when it seemed that it stopped getting any updates from Unleash. It was caused by the update in unleash-client release 5.2 because it stops fetching Unleash configuration when it encounters status codes 401, 403 or 404. Please see handleErrorCases function. I agree that it seems like a configuration issue, but in my opinion, after the successful initial fetch, it doesn't make sense to just stop pulling updates from Unleash in case a single 404 is encountered.

Steps to reproduce the bug

No response

Expected behavior

No response

Logs, error output, etc.

No response

Screenshots

No response

Additional context

No response

Unleash version

No response

Subscription type

None

Hosting type

None

SDK information (language and version)

No response

HenrikBacher commented 3 months ago

Issue seems to have been introduced with #537 I think it would make sense to extend the retry logic to also cover 404 errors