Closed nunogois closed 2 months ago
Not sure it needs a major version because the code will still work if you pass an object with an instanceId
Not sure it needs a major version because the code will still work if you pass an object with an
instanceId
It matters for TypeScript, sadly (actually strongly mixed feelings?). I thought the same thing so I went and checked and yes the compiler does complain
:old-man-yells-at-typescript:
What about Unleash-API-compatible providers like Gitlab Feature Flags, that do require an instanceId
? Does this mean the sdks/clients will be incompatible with these providers after this change?
https://linear.app/unleash/issue/2-2397/make-instance-id-autogenned-node
This makes
instanceId
an automatically generated property, instead of being set by the user.Similar to https://github.com/Unleash/unleash-client-ruby/pull/179 Similar to https://github.com/Unleash/unleash-client-dotnet/pull/226