Unleash / unleash-client-php-wip

PHP client for Unleash
Apache License 2.0
11 stars 14 forks source link

how to help getting this library to work? #12

Open kaystrobach opened 5 years ago

kaystrobach commented 5 years ago

please give a hint, maybe we can figure something out.

ivarconr commented 5 years ago

I think the most critical point is to handle the state caching and updating of that cache. I think that has to be an API provided by the user of this library. State can be stored in database, redis, on disk etc.

kaystrobach commented 5 years ago

So it would be fine having an psr example?

So that you know how to handle that caching stuff?

Do you need a commandController to check for new data as example implementation?

ivarconr commented 5 years ago

Yes I think this would be a good idea.

On Thu, 4 Jul 2019 at 16:37, Kay Strobach notifications@github.com wrote:

So it would be fine having an psr example?

So that you know how to handle that caching stuff?

Do you need a commandController to check for new data as example implementation?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/Unleash/unleash-client-php/issues/12?email_source=notifications&email_token=AABGZZE4ZP4KFCOOMMOZQITP5YDKLA5CNFSM4H5RXG6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZHSTZI#issuecomment-508504549, or mute the thread https://github.com/notifications/unsubscribe-auth/AABGZZG3XJVBDOSFFZG4K2TP5YDKLANCNFSM4H5RXG6A .

kaystrobach commented 5 years ago

will try to provide a solution in the next weeks. should not be that hard.

ivarconr commented 5 years ago

Cool, and much appreciated!

I start my summer vacation today, so I've added you as collaborator with write access to allow you to have progress!

kaystrobach commented 5 years ago

thank you, i started on the fork i made and created an easy pr. it should show how easy it is to add caching.

kaystrobach commented 5 years ago

each using framework should add a psr16 cache into the client on creation (construct) and then it should not be to hard to addopt this lib to symfony, flow, zend, etc, als they all have an psr16 compatible cache

iGitScor commented 4 years ago

Hi, do you need any help ?

kaystrobach commented 4 years ago

the question is if we should make a call or something similar to organize the work to be done.

IMHO we should do the following things:

ivarconr commented 4 years ago

Could we try to coordinate it on slack? Let me know how I can support you.

kaystrobach commented 4 years ago

sure

frazjp65 commented 4 years ago

@kaystrobach, @ivarconr, what still needs to be done to get this into a usable state?

kaystrobach commented 4 years ago

There is a rather large PR you may hop on and help testing. I mainly restructure the code and make it psr compliant

kaystrobach commented 4 years ago

And you can sponsor that - make it easier to concentrate on he project