Open kaystrobach opened 5 years ago
I think the most critical point is to handle the state caching and updating of that cache. I think that has to be an API provided by the user of this library. State can be stored in database, redis, on disk etc.
So it would be fine having an psr example?
So that you know how to handle that caching stuff?
Do you need a commandController to check for new data as example implementation?
Yes I think this would be a good idea.
On Thu, 4 Jul 2019 at 16:37, Kay Strobach notifications@github.com wrote:
So it would be fine having an psr example?
So that you know how to handle that caching stuff?
Do you need a commandController to check for new data as example implementation?
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/Unleash/unleash-client-php/issues/12?email_source=notifications&email_token=AABGZZE4ZP4KFCOOMMOZQITP5YDKLA5CNFSM4H5RXG6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZHSTZI#issuecomment-508504549, or mute the thread https://github.com/notifications/unsubscribe-auth/AABGZZG3XJVBDOSFFZG4K2TP5YDKLANCNFSM4H5RXG6A .
will try to provide a solution in the next weeks. should not be that hard.
Cool, and much appreciated!
I start my summer vacation today, so I've added you as collaborator with write access to allow you to have progress!
thank you, i started on the fork i made and created an easy pr. it should show how easy it is to add caching.
each using framework should add a psr16 cache into the client on creation (construct) and then it should not be to hard to addopt this lib to symfony, flow, zend, etc, als they all have an psr16 compatible cache
Hi, do you need any help ?
the question is if we should make a call or something similar to organize the work to be done.
IMHO we should do the following things:
Could we try to coordinate it on slack? Let me know how I can support you.
sure
@kaystrobach, @ivarconr, what still needs to be done to get this into a usable state?
There is a rather large PR you may hop on and help testing. I mainly restructure the code and make it psr compliant
And you can sponsor that - make it easier to concentrate on he project
please give a hint, maybe we can figure something out.