search

Unleash / unleash-client-php

Unleash client SDK for PHP
MIT License
55 stars 14 forks source link

Chore/bump client spec version #223

Closed sighphyre closed 4 months ago

sighphyre commented 4 months ago

Moves the version of the client specification that's advertised to Unleash to 5.0.2 in order to match the version that this SDK is actually tested against.

@RikudouSage this is probably a cheap patch to get the versions matching again but ideally the version would always match and be enforced at build time. Most of the other SDKs now just clone a shallow snapshot of the repo to the tag that matches the source code when it's being run in CI. Are you deeply attached to using a submodule for the client spec because forcing the versions to match isn't quite as easy with the submodule

RikudouSage commented 4 months ago

I wasn't aware that part needs updating, I think I didn't have any part in developing this. I see this does not go into main, but a feature branch.

I'm not deeply attached to it, though I rather like it being linked. Shouldn't it just be possible to check what revision is the cloned repository at and if it does not match, fail? Should be just a few git commands, shouldn't it?

sighphyre commented 4 months ago

Shouldn't it just be possible to check what revision is the cloned repository at and if it does not match, fail? Should be just a few git commands, shouldn't it?

Yeah actually that sounds pretty reasonable and less invasive