search

Unleash / unleash-client-python

Unleash client SDK for Python 💡💡💡
http://unleash.github.io/unleash-client-python
MIT License
84 stars 60 forks source link

Support semver >= 3.0.0 as a dependency #276

Closed beljul closed 1 year ago

beljul commented 1 year ago

Is your feature request related to a problem? Please describe. I have a conflict with another package (https://github.com/flairNLP/flair) which requires semver<4.0.0,>=3.0.0.

Describe the solution you'd like Could you please tell me if the unleash client could support semver >= 3.0.0 instead of enforcing semver < 3.0.0 ?

ilee-asapp commented 1 year ago

I pinned semver because - at the time of implementation - they mentioned 3.0.0 with API changes was on the horizen.

We can def. revisit that - I think most of the changes were unrelated to how ucp is using the library. I'll see if I can peek later this week!

chaitanya-parsana commented 1 year ago

Hi, Trying to use unleash with Lancedb, and having the same issue with dependency resolution error on semver versioning.

unleashclient 5.8.0 depends on semver<3.0.0 lancedb 0.3.2 depends on semver>=3.0

chaitanya-parsana commented 1 year ago

I have a draft here: #280 Please let me know if you'd like any changes.

ivanklee86 commented 1 year ago

Apologies, life kind of ambushed me.

PR looks good, let me get a new release rolling. :)

ilee-asapp commented 1 year ago

This is in v5.9.1 which is up on Pypi! :)

beljul commented 1 year ago

Sounds good to me, thanks a lot for your reactivity ! :pray: