search

Unleash / unleash-client-rust

Unleash client SDK for Rust language projects
Apache License 2.0
23 stars 17 forks source link

fix ci: extract MSRV build from standard matrix #58

Closed thomasheartman closed 1 year ago

thomasheartman commented 1 year ago

(Description last updated at: 2023-06-20T09:46:36+02:00)

Simplify the CI build matrices as suggested in #56.

This PR removes our MSRV build from the standard build matrix and creates a new job called msrv. The msrv job builds the project using the release and no-default-fetaures flags.

To try and keep the builds more consistent, this PR also includes a Cargo.lock.msrv file. The file doesn't come into play for non-MSRV builds, but gets renamed before the MSRV build to pin the dependencies.

On building MSRV without tests

While the build works with MSRV, the test fail. This appears to be due to a dev dependency on Tokio that requires a more recent version of time than we can use with the MSRV. As such (and because we already run tests on stable, beta, and nightly), I have removed the test stage from the MSRV jobs.

rbtcollins commented 1 year ago

The reason to have nightly and/or beta there is forward warning of changes that would impact us; that lets us engage upstream rather than only finding out after the fact. We can always disable if there is a persistent breakage, but I don't think we've seen that so far.