Unleash / unleash-client-rust

Unleash client SDK for Rust language projects
Apache License 2.0
23 stars 18 forks source link

Fix: Fix variant distribution #69

Closed thomasheartman closed 10 months ago

thomasheartman commented 10 months ago

(Mostly copied from the same fix for the Go SDK)

What

This PR does a few things, all related to using a new seed for ensuring a fair distribution for variants.

Background

After a customer reported that variant distribution seemed skewed we performed some testing and found that since we use the same hash string for both gradual rollout and variant allocation we'd reduced the set of groups we could get to whatever percentage our gradual rollout was set.

Example

Take a gradualRollout of 10%, this will select normalized hashes between 1 and 10, when we then again hash the same string that gave us between 1 and 10, but with modulo 1000 for variants, this will only give us 100 possible groups, instead of the expected 1000.

Fix

Force the normalization to accept a seed, and make sure to use a new seed when normalizing the variant distribution hash.

Worth noting

This will require releasing a new minor version, since we are changing how hashing works on a pre-1.0 package.

thomasheartman commented 10 months ago

Whoops. Forgot to squash my commits before merging. Genuinely sorry 🙇🏼