Unleash / unleash-edge

MIT License
48 stars 8 forks source link

fix: add timeout for redis read and write ops. #478

Closed chriswk closed 2 months ago

chriswk commented 2 months ago

Previously, if you gave us a redis url that was valid, but used the wrong protocol (so rediss when connecting to insecure, or redis when connecting to secure), operations against Redis got stuck. This PR adds a timeout setting (setting it to default of 2000 ms, but configurable).

This does add time when url is completely invalid (i.e. there's nothing listening), but it prevents the client from getting stuck indefinitely if something answers, but redis can't get an answer.

github-actions[bot] commented 2 months ago

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files