Unleash / unleash-express

Unleash helper for Express.js
6 stars 2 forks source link

Normalize the stack #1

Open elhoyos opened 5 years ago

elhoyos commented 5 years ago

With the intention to increase the support of this project under the Unleash organization, it would be desirable to make it follow the same stack of unleash-client-node.

I'm opening this issue to build a consensus on what would be the scope of that stack. I will start with a briefing of the current situation and then I will include possible changes.

unleash-express is an express.js middleware that keeps the results of all calls to isEnabled and experiment (later on this) in-sync with a browser cookie.

It depends on a forked version of unleash-client-node that implements variants via client.experiment and is incompatible with our latest upstream variant version (https://github.com/Unleash/unleash/pull/379).

Tests are implemented with ava and supertest. So that part is similar to what we have in unleash and unleash-client-node.

Proposed changes:

Nice to have:

Thank you for embracing this common effort.

nathanredblur commented 5 years ago

Unleash should have a way to get to export the cars by an api to allow work with single aplicaciones like react or angular.

dmaevac commented 5 years ago

These seem like very sensible ideas, I dont believe they need much discussion. Normalizing the stack benefits everyone working in the unleash ecosystem.