search

Unleash / unleash-proxy-client-js

A browser client that can be used together with the unleash-proxy.
Apache License 2.0
44 stars 46 forks source link

fix: don't send empty If-None-Match header #187

Closed cmalard closed 6 months ago

cmalard commented 6 months ago

About the changes

Our network firewall blocks the requests made, because the header If-None-Match is sent with an empty value, which is considered a violation.

According to MDN's doc:

image

*So I removed it when empty to match the spec ;)

Tymek commented 6 months ago

Can it be unset (as in not present), instead of asterisk or empty? https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/If-None-Match#sect1