search

Unleash / unleash-proxy-client-js

A browser client that can be used together with the unleash-proxy.
Apache License 2.0
44 stars 46 forks source link

Missing `currentTime` in Unleash Context object #194

Closed AdrienFromToulouse closed 5 months ago

AdrienFromToulouse commented 6 months ago

Describe the bug

The currentTime property https://docs.getunleash.io/reference/unleash-context seems to be missing.

https://github.com/Unleash/unleash-proxy-client-js/blob/main/src/index.ts#L9

Cheers!

Steps to reproduce the bug

Try to set the currentTime property on the context, it would result in noop.

Expected behavior

Take the currentTime property into account

Logs, error output, etc.

No response

Screenshots

No response

Additional context

No response

Unleash version

3.2.0

Subscription type

Pro

Hosting type

Hosted by Unleash

SDK information (language and version)

"@unleash/proxy-client-react": "^4.1.1"

sjaanus commented 5 months ago

This is released as part of https://github.com/Unleash/unleash-proxy-client-js/releases/tag/v3.3.1

AdrienFromToulouse commented 5 months ago

Thanks!

AdrienFromToulouse commented 5 months ago

@sjaanus will it be incorporated to https://github.com/Unleash/proxy-client-react anytime soon?

I can see it is still using a beta version https://github.com/Unleash/proxy-client-react/blob/main/package.json#L53

Cheers,