search

Unleash / unleash-proxy-client-js

A browser client that can be used together with the unleash-proxy.
Apache License 2.0
44 stars 46 forks source link

fix: adds content type only on post method #198

Closed mohsen-khalili closed 3 months ago

mohsen-khalili commented 4 months ago

In sdk for set GET request adds content type in header but not necessary and common waf unit block this request, i change code and set content type header adds only in POST request.

[Closes #197 ]

mohsen-khalili commented 3 months ago

Thanks for review I fixed test for check header in GET and POST request please check it @thomasheartman

thomasheartman commented 3 months ago

Oh, @mohsen-khalili, one more thing: CI is failing because the formatting is inconsistent with prettier. Can you make sure you run prettier on src/index.ts, please? 

yarn run v1.22.22
$ prettier src --check && eslint src
Checking formatting...
[warn] src/index.ts
[warn] Code style issues found in the above file. Run Prettier to fix.
mohsen-khalili commented 3 months ago

I fixed it Sorry, it took a while

thomasheartman commented 3 months ago

No worries at all! I'll merge once the build succeeds. Thanks again ☺️

chriswk commented 3 months ago

Released in v3.3.2