search

Unleash / unleash-proxy-client-js

A browser client that can be used together with the unleash-proxy.
Apache License 2.0
47 stars 46 forks source link

Align the refreshInterval to either milliseconds or seconds across all libraries/SDKs #85

Closed sambenskin closed 2 years ago

sambenskin commented 2 years ago

Describe the feature request

When I was configuring my unleash proxies and SDKs, I noticed that in some places, the docs and code show that refreshInteval is in seconds, but in other SDKs it's in milliseconds.

This causes some confusion when there is unleash-proxy-client-js, unleash-proxy-node, unleash-proxy-react and using these client side or server side, it could easily be misconfigured.

Discussing on the slack group, it was asked that I raise the issue here so that it can be addressed, perhaps in the next major version.

Thanks for an amazing product and for releasing it to the open source community.

Background

Original discussion: https://unleash-community.slack.com/archives/CGN5JT69F/p1652975702243299

Solution suggestions

In the next major version, create a new variable name and make it milliseconds, in case anyone wants some some quick updates to happen.

nunogois commented 2 years ago

Hi @sambenskin - Thanks for opening this issue! We've seen this and will get back with more information soon.

nunogois commented 2 years ago

This issue was internally discussed and we have decided to take it into account for a later development, maybe the next major version like you suggested. Thank you for your contribution!

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.