Unleash / unleash-proxy

Unleash Proxy is used to safely integrate frontend application with Unleash in a secure and scaleable way.
https://docs.getunleash.io/sdks/unleash-proxy
Apache License 2.0
48 stars 42 forks source link

Add CurrentTime to createRequestParameters #160

Closed AdrienFromToulouse closed 5 months ago

AdrienFromToulouse commented 5 months ago

Describe the feature request

Hi,

Following https://github.com/Unleash/unleash-proxy-client-js/pull/195 and https://github.com/Unleash/proxy-client-react/pull/158 I think we should also have the CurrentTime prop available here? https://github.com/Unleash/unleash-proxy/blob/main/src/unleash-proxy.ts#L79-L84

Cheers,

Background

No response

Solution suggestions

No response

sighphyre commented 5 months ago

Hey, thanks, good catch. This probably should be in here. I'll patch this in the next few days

Just a warning, this project is approaching end of life. We strongly recommend using Unleash Edge instead

AdrienFromToulouse commented 5 months ago

oh was not aware of Unleash edge. Thank you for the upcoming update, in the meantime we will plan a rollout out of Unleash edge I guess.

sighphyre commented 5 months ago

@AdrienFromToulouse It's not urgent to upgrade, the Proxy will be around for a long, long time. Probably at some point this year we'll formally mark this project as hitting EOL, but that will mostly just mean we won't add new features, we'll continue to do bugfixes and security updates as needed

We've released v1.1.0 of the Proxy, which should now accept current time

AdrienFromToulouse commented 5 months ago

@AdrienFromToulouse It's not urgent to upgrade, the Proxy will be around for a long, long time. Probably at some point this year we'll formally mark this project as hitting EOL, but that will mostly just mean we won't add new features, we'll continue to do bugfixes and security updates as needed

We've released v1.1.0 of the Proxy, which should now accept current time

@sighphyre sweeeeeet. Thank you so much for the quick update ❤️ really appreciate.

sighphyre commented 5 months ago

Nothing but a pleasure!