search

Unleash / unleash-spring-boot-starter

Apache License 2.0
1 stars 7 forks source link

RestController Documentation #30

Closed malte-baumann closed 6 months ago

malte-baumann commented 6 months ago

I believe the Example of an RestController in the README File contains a wrong annotation.

What it says: 

@GetMapping
    public String feature(@RequestMapping @Context(name = "name") final String name) {
        return featureDemoService.getDemoString(name);
    }

What it should say: 

@GetMapping
    public String feature(@RequestParam @Context(name = "name") final String name) {
        return featureDemoService.getDemoString(name);
    }
daveleek commented 6 months ago

Thank you for raising and fixing this @malte-baumann! Your PR has been approved, feel free to merge!

daveleek commented 6 months ago

Thank you @malte-baumann, we merged your PR and are closing this issue!