search

Unleash / unleash-spring-boot-starter

Apache License 2.0
1 stars 8 forks source link

Unable to use own InstanceId #7

Closed ajdergute closed 2 years ago

ajdergute commented 2 years ago

https://github.com/Unleash/unleash-spring-boot-starter/blob/2dc91045c2bea988261a3c4e80cda6e6d652b959/springboot-unleash-autoconfigure/src/main/java/org/unleash/features/config/UnleashAutoConfiguration.java#L64

I assume the exclamation mark in this line should be removed. If I configure my instanceId a UUID is used instead.

checketts commented 2 years ago

Agreed. Good find

praveenpg commented 2 years ago

unleashProperties.getInstanceId() is the instance Id that you will be configuring.

praveenpg commented 2 years ago

Great find @ajdergute. I will create a PR with the change

praveenpg commented 2 years ago

@ajdergute Created a PR https://github.com/Unleash/unleash-spring-boot-starter/pull/12

ajdergute commented 2 years ago

LGTM

ajdergute commented 1 year ago

Would be really nice to see this as a release on maven central.