Unleash / unleash

Open-source feature management solution built for developers.
https://getunleash.io
Apache License 2.0
11.08k stars 693 forks source link

Semver operator equal or greater than #4323

Open dprevost-LMI opened 1 year ago

dprevost-LMI commented 1 year ago

Describe the feature request

Hey, first, nice job supporting the Semantic versioning operator!

Yes, I know it already exists by doing negate of less than, but would it be easy to provide a precise "equal or greater than" so it is easy to read and choose?

Background

This would help us with clarity and readability since it is way easier to understand "equal or greater than" while "negation of less than" kind of needs a second to revert it in my mind!

Having it would remove some ambiguity and make life easier 😄

Solution suggestions

Under the hood, I guess it simply to do the "negate of less than," and it would remove soo much ambiguity.

Thanks!!

Nezz commented 1 year ago

We'd also love to have those operators

Okhoshi commented 1 year ago

There's also a subtile but important difference between a real "equal or greater than" and "negation of less than", it's the case when the field is missing.

If the field is empty, it can't satisfy "equal or greater than" while it will always satisfy "negation of less than".

sighphyre commented 1 year ago

Hey folks, this seems like a pretty good thing to have but this isn't likely something that we'll do right now. I've marked this as "maybe layer" so our bot doesn't close the PR, we'll look into it

ivarconr commented 1 year ago

This would require us to update all server-sdks, edge and proxy first withe the lte and gtw support. The work in each SDK will be straight forward.

In the Node SDK it would simply be to add two more (if clauses here).

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

dprevost-LMI commented 1 year ago

Please keep it open!

stale[bot] commented 11 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

dprevost-LMI commented 11 months ago

Please consider doing so since it should be simple and make life so much easier and minimize mistaken

dprevost-LMI commented 10 months ago

An experienced developer just asked me that he was not finding the greater than and had to explain what to use. If only things could be clear 😄

Nezz commented 10 months ago

This would require us to update all server-sdks, edge and proxy first withe the lte and gtw support. The work in each SDK will be straight forward.

@ivarconr I wonder if the web UI of unleash could translate "GTE" into "not LT" when it sends the feature configuration to the SDK? That way this functionality could be added without requiring SDK updates.

sighphyre commented 10 months ago

Hey folks, I see lots of interest in this one. Apologies for our bot closing this, I've put a pinned label on this, hopefully that should keep the bot at bay!

We're working on an architecture change that should make this much easier to implement but it's a fairly large project. We haven't forgotten about this, there's just a bit of ground work that needs to be done to make this kind of change easier.

reflog commented 1 month ago

any updates on this?