thomasheartman commented 6 days ago

This PR updates the project status service (and schemas and UI) to use the project's current health instead of the 4-week average.

I nabbed the calculateHealthRating from src/lib/services/project-health-service.ts instead of relying on the service itself, because that service relies on the project service, which relies on pretty much everything in the entire system.

However, I think we can split the health service into a service that does need the project service (which is used for 1 of 3 methods) and a service (or read model) that doesn't. We could then rely on the second one for this service without too much overhead. Or we could extract the calculateHealthRating into a shared function that takes its stores as arguments. ... but I suggest doing that in a follow-up PR.

Because the calculation has been tested other places (especially if we rely on a service / shared function for it), I've simplified the tests to just verify that it's present.

I've changed the schema's averageHealth into an object in case we want to include average health etc. in the future, but this is up for debate.

vercel[bot] commented 6 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
unleash-monorepo-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 20, 2024 10:37am

1 Skipped Deployment

github-actions[bot] commented 6 days ago

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Unleash / unleash

chore(1-3133): change avg health to current health in project status #8803

Dependency Review

OpenSSF Scorecard

Scanned Files