Unleash / unleash

Open-source feature management solution built for developers.
https://getunleash.io
Apache License 2.0
11.46k stars 721 forks source link

fix: don't break personal dashboard charts if the flag is called `.` #8807

Closed thomasheartman closed 6 days ago

thomasheartman commented 6 days ago

This PR fixes an issue where the personal dashboard would fail to render if the flag was called . (Curiously, it was not an issue with ..; probably because they end up accessing different URLs).

I've taken the very pragmatic approach here of saying "right, we know that . and .. cause issues, let's just not even try to fetch data for them".

The option, of course, is to bake in more error handling in the components, but due to how we've got hooks depending on each other, it's a bit of a rabbit hole to go down. I think this is a good compromise for now.

So now, you'll get this instead: image

I've also gone and updated the text for when we get a metrics fetching error, because this probably isn't due to the flag name anymore. If it is, we want to know.

vercel[bot] commented 6 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 1:17pm
1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **unleash-docs** | ⬜️ Ignored ([Inspect](https://vercel.com/unleash-team/unleash-docs/CAk6rE9VW5NBHah4cpGapXf3yRdn)) | [Visit Preview](https://unleash-docs-git-1-3132-dont-break-charts-i-ca078e-unleash-team.vercel.app) | | Nov 20, 2024 1:17pm |
github-actions[bot] commented 6 days ago

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files