UnlikePaladin / paladins-furniture

Paladin's Furniture Mod
GNU Lesser General Public License v3.0
18 stars 13 forks source link

[BUG] Several problems with structure blocks and furniture #121

Open cecaelion opened 7 months ago

cecaelion commented 7 months ago

Bug Description

This is a truly fantastic mod- I love the furniture options it gives me and the versatility of decoration. However, I have noticed a number of problems when using PFM pieces in structures I save using Structure Blocks (eg, for use in a datapack). I apologize in advance for the number of screenshots, but I wanted to thoroughly document the issue.

All behavior reported and screenshots taken are from an instance using Minecraft 1.20.1, the latest version of the Fabric modloader and Fabric API, as well as the latest version of PFM for Fabric 1.20.1. As a note, this also happens using Quilt.

The largest problem that I have noticed is that using simple lights in a build saved with a Structure Block will completely destroy the saved build. Upon loading that build with a structure block, most of the furniture disappears (except for tables, chairs, toilet paper rolls, and counters), as well as several of the slab and stair blocks used in the build. This did not happen with my test world, but I have also seen glass panes disappear.

Without simple lights, the same build will save and load almost correctly using a structure block, with the exception of a few blocks: most wall fixtures (wall cabinets, shower handles, etc), freezers, and any lamps. However, everything else remains untouched.

Reproduction Steps

  1. Load an instance of Minecraft 1.20.1 with the Fabric modloader, Fabric's API, and Paladin's Furniture Mod.

  2. Build a simple house using a mixture of vanilla materials and some PFM furniture (example shown below). 2024-04-21_20 54 37 2024-04-21_20 54 49 2024-04-21_20 54 59 2024-04-21_20 55 06 2024-04-21_20 55 38

  3. Save this structure with a Structure Block (mine was saved as wintyr:house-1).

  4. Load the same structure again nearby. The majority of PFM's wall furniture has disappeared from the copy, as have the lamps and the freezer. 2024-04-21_20 56 43 2024-04-21_20 56 54 2024-04-21_20 57 03 2024-04-21_20 57 12 2024-04-21_20 57 18

  5. Alter the build from step 2 or its reloaded version from step 4, but instead of lamps, use PFM simple lights on the ceilings and nearby light switches to control them. 2024-04-21_20 59 13 2024-04-21_20 59 19 2024-04-21_20 59 24 2024-04-21_20 59 32

  6. Save the altered build as a separate build from the first save of it (I used wintyr:house-2).

  7. Using a structure block, load the build saved in step 6. Now, not only have the wall furniture, lamps, and freezer disappeared, but the majority of the furniture along with multiple vanilla slabs and stairs have also disappeared. 2024-04-21_21 00 05 2024-04-21_21 00 13 2024-04-21_21 00 21 2024-04-21_21 00 31 2024-04-21_21 00 37

Log File

latest.log (There are a few errors initially logging into the world because I had already tested this issue using that world with the Quilt modloader, but thought I should also see if it happened using Fabric as well. I redid the entire test from the second step onwards to take these screenshots.)

Additionally, the structures used in my screenshots: wintyr.zip