search

UnlimitedHugs / RimworldAllowTool

A set of tools to simplify common tasks in Rimworld.
https://ludeon.com/forums/index.php?topic=17218.0
Other
60 stars 34 forks source link

Conflict with Save Our Ship 2 #29

Closed KiameV closed 4 years ago

KiameV commented 4 years ago

There is a problem with Save Our Ship 2 mod. When a shuttle is selected to hover, it will become a Pawn so it can move on the map. The problem is, the pawn-like shuttles lack a Name. This causes the group hunt Gizmo constructor to throw a null pointer exception.

This PR will prevent group hunt constructor from being called by first verifying the pawn has a Name. If the pawn does not have a Name this change will prevent a Gizmo from being created for hunting.

UnlimitedHugs commented 4 years ago

Thank you, the fix is released. Looks to be working, though the shuttle pawn seems to be causing some other errors unrelated to Allow Tool: ShuttleCargoRace3933 has no available melee attack and Could not instantiate Verb (directOwner=ShuttleCargoRace3933): System.MissingMethodException: Cannot create an abstract class 'RimWorld.Verb_MeleeAttack'.

KiameV commented 4 years ago

Indeed there are other errors. I'm not part of the Save Our Ship mod team and their code is not open source (as far as i can see). So I fixed what i could.

Thanks for accepting the PR.