UnlimitedHugs / RimworldHugsLib

A lightweight shared library for Rimworld modding.
Other
245 stars 59 forks source link

Separate news #57

Closed FluffierThanThou closed 4 years ago

FluffierThanThou commented 4 years ago

I'm afraid I have mangled your project file - sorry!

That said, news should now be loaded from the News folder (respecting versioned folders), and also be allowed for mods that do not inherit from ModBase. I've made some changes to how Versions are fetched to accomodate (as well as adding support for ModManager's Manifest.xml file).

Those that inherit ModBase will be matched based on the identifier provided there, those that do not will be matched based on their packageId.

Re; using packageId's instead of ModBase identifiers: that only works as long as there is one ModBase per mod. I'm not sure if that is necessarily true?

diddily commented 4 years ago

I hadn't thought about the possibility of multiple ModBase per Mod, that is a very good point (though I can't think of why you'd necessarily want to do that). It could use the PackageId as the default going forward instead I suppose.

UnlimitedHugs commented 4 years ago

Nice work! I decided to start with a direct port of HugsLib to 1.1, which will be published in a separate (and temporary) workshop item. Once that is up, we have some breathing room and can make breaking changes. At that point I can merge this, though, perhaps, you will like to rebase your changes against the new build. I'll post a comment when the new build is live.

As for the mod id's, I'll probably take @diddily 's suggestion and just use the id from About.xml for each mod. This should simplify things.