Closed KiameV closed 3 years ago
Merged, hope you didn't mind the wait too much ;) Also, updated the description on Steam to point to your mod, rather than Rainbeau's.
I noticed an error while doing some quick testing- looks like it might be addressable on your end. Happens when pressing "Configure map" while the settings window is already open.
Exception while saving ConfigurableMaps.Settings: System.NullReferenceException: Object reference not set to an instance of an object
at ConfigurableMaps.CurrentSettings.ApplySettings (System.Collections.Generic.List`1[T] fvs) [0x00000] in <ec9ae265f2134ebe94fcd6d21e0d6797>:0
at ConfigurableMaps.Settings.ExposeData () [0x00058] in <ec9ae265f2134ebe94fcd6d21e0d6797>:0
at Verse.Scribe_Deep.Look[T] (T& target, System.Boolean saveDestroyedThings, System.String label, System.Object[] ctorArgs) [0x00167] in <b64badbf3c3d41018b3ca5d3e8c77771>:0
UnityEngine.StackTraceUtility:ExtractStackTrace ()
Verse.Log:Error (string)
Verse.Scribe_Deep:Look<Verse.ModSettings> (Verse.ModSettings&,bool,string,object[])
Verse.Scribe_Deep:Look<Verse.ModSettings> (Verse.ModSettings&,string,object[])
Verse.LoadedModManager:WriteModSettings (string,string,Verse.ModSettings)
Verse.ModSettings:Write ()
Verse.Mod:WriteSettings ()
RimWorld.Dialog_ModSettings:PreClose ()
Verse.WindowStack:TryRemove (Verse.Window,bool)
Verse.WindowStack:RemoveWindowsOfType (System.Type)
Verse.WindowStack:Add (Verse.Window)
MapReroll.Compat.Compat_ConfigurableMaps:ExtraMapPreviewsDialogOnGUI (MapReroll.UI.Dialog_MapPreviews,UnityEngine.Rect)
MapReroll.UI.Dialog_MapPreviews:DoWindowContents (UnityEngine.Rect)
Verse.Window:InnerWindowOnGUI (int)
UnityEngine.GUI:CallWindowDelegate (UnityEngine.GUI/WindowFunction,int,int,UnityEngine.GUISkin,int,single,single,UnityEngine.GUIStyle)
For 1.3 I rewrote Configurable Maps. As part of that rewrite I consolidates the two settings pages to one. That change caused this compat to stop working.