UnlockedLabs / UnlockEdv2

UnlockedLabs' WIP education portal/SIS for capturing meaningful progress of incarcerated learners in external providers, to help earn good time credits
5 stars 18 forks source link

some classes do not comply with psr-4 autoloading standard #192

Closed kcassam closed 6 months ago

kcassam commented 6 months ago

Describe the bug when running composer install :

Generating optimized autoload files
Class Tests\Feature\UserCourseActivityJob located in ./tests/Feature/UserCourseActivityJobTest.php does not comply with psr-4 autoloading standard. Skipping.
Class Tests\Feature\CanvasIntegrationTests located in ./tests/Feature/CanvasIntegrationTest.php does not comply with psr-4 autoloading standard. Skipping.
Class App\Entities\IdentityEntity located in ./app/Entities/UserEntity.php does not comply with psr-4 autoloading standard. Skipping.

To Reproduce Steps to reproduce the behavior:

Expected behavior All classes should comply with psr-4 autoloading standard

Screenshots If applicable, add screenshots to help explain your problem.

Capture d’écran 2024-04-13 à 11 38 15
PThorpe92 commented 6 months ago

Yeah thanks for reporting this!

Saw this one in the initial loading of phpstan locally. Fixed these and a bunch more issues and got the lint level up to 2 from 0 in #196 :D

Unfortunately a good amt of the work fixing a lot of the other lints was more just getting Phpstan to recognize relationships and methods/fields, but with the amount of actual issues that it found, it was worth fighting with it for a day.