The Japanese font size is too big where the Axolotl font is applied.

Foxy-null commented 3 months ago

The Japanese characters are unusually large.

The topic shifts, but a reproduction of the Japanese font used in Pokémon for the Game Boy is available. It only supports hiragana, katakana, Latin (English), and some symbols, but feel free to check it out if you're interested.

Pokemon GB Font list

Reference pages for the Japanese font

The "Pokemon GB Font" page

Unlucky-Life commented 3 months ago

do you know if that font is free to use ?

Unlucky-Life commented 3 months ago

the issue with that font is that Hiragana and the Katakana Files are seperate => this issue being that those files are seperated and the file that uses the descriptions for the pokemon is merged in one category category ("language 1 = hiragana and katakana)

i would need a file that merges these two alphabets

Foxy-null commented 3 months ago

Actually, there's another version of a Japanese font that merges both katakana and hiragana in one font file. However, since the license was not clearly stated, I avoided mentioning it. I'll send the distribution page for that font in the comments shortly.

Foxy-null commented 3 months ago

Here it is!

The "ポケモンフォント(Pokemon Font)" page, Direct download URL, Font: Overview of included characters, Pokemon Font Glyph List (Unicode Order)

Unlucky-Life commented 3 months ago

so i tried those fonts - but somehow they are not loading properly

Unlucky-Life commented 3 months ago

ok i may have found the issue. Can you check if the characters here are correct ? (ill change the sizing after)

Unlucky-Life commented 3 months ago

here is a good font you can use: license: Freeware, Non-Commercial link: https://www.fontspace.com/nineteen-ninety-three-font-f29544 => for non-commercial, freeware Nineteen-Ninety-Three-Font by Chequered Ink

download the file named above - and drag and drop the NineteenNinetyThree-L1Ay.ttf file into the addon_files folder
or you can now download the Early GameBoy.ttf file from the github addon_files folder. https://github.com/Unlucky-Life/ankimon/blob/5fc1905647a9bcc3adc287e3d959f7afc023ab68/src/Ankimon/addon_files/Early%20GameBoy.ttf
then download the init.py file from the github and replace the one into the ankimon folder
https://github.com/Unlucky-Life/ankimon/blob/bfcead09bd53103da13a5de5c7ef792cac1a0061/src/Ankimon/__init__.py

This should change the size issue:

Unlucky-Life commented 3 months ago

Foxy-null commented 3 months ago

ok i may have found the issue.

Can you check if the characters here are correct ?

(ill change the sizing after)

Wow... what a strange way of displaying things. It seems like English was the worst match. I should have tried it in my own environment before recommending it. I'm sorry.

Foxy-null commented 3 months ago

here is a good font you can use: license: Freeware, Non-Commercial

link: https://www.fontspace.com/nineteen-ninety-three-font-f29544

=> for non-commercial, freeware

Nineteen-Ninety-Three-Font by Chequered Ink

download the file named above - and drag and drop the NineteenNinetyThree-L1Ay.ttf file into the addon_files folder

or you can now download the Early GameBoy.ttf file from the github addon_files folder.

https://github.com/Unlucky-Life/ankimon/blob/5fc1905647a9bcc3adc287e3d959f7afc023ab68/src/Ankimon/addon_files/Early%20GameBoy.ttf

then download the init.py file from the github and replace the one into the ankimon folder

https://github.com/Unlucky-Life/ankimon/blob/bfcead09bd53103da13a5de5c7ef792cac1a0061/src/Ankimon/__init__.py

This should change the size issue:

Thank you for the alternative suggestion. I'll try it out right away. If I find another promising font, I'll test it in my own environment before letting you know next time!

Foxy-null commented 3 months ago

Sorry for the late reply. This works really nicely! Thank you for your continuous support!

Foxy-null commented 3 months ago

ok i may have found the issue. Can you check if the characters here are correct ? (ill change the sizing after)

The lowercase alphabets were corrupted, but this was fixed by changing the font to "Western". I also made some changes to make them more similar to certain authentic Pokémon.

I'll create a pull request for these changes; could you please review it?

[x] Change Japanese font
- Bug fix for displaying voiced and semi-voiced Japanese characters in the Pokédex description for Pokémon names.
[x] Switched the Pokémon gender display to use male and female symbols
- For Pokémon without gender, no symbols are displayed.
[x] Created a Japanese versions of the text "A wild 'pokemon' has appeared" text.
- It seems that even though I used "\n", the line break wasn't applied as intended in the middle of the sentence.