Unlucky-Life / ankimon

Ankimon is a Anki Addon to Gamify your learning experience
Other
69 stars 6 forks source link

"caught first legendary" badge labelled as "first baby pokemon" #68

Closed omfgroflmfaol closed 5 months ago

omfgroflmfaol commented 5 months ago

after catching the legendary pokemon uxie, the message said that I received the badge for catching my first baby pokemon. I already had that badge before. Seems that the labels got mixed up:

image
face515 commented 5 months ago

Just a theory, but in an earlier issue, someone pointed out the order that types of pokemon showing up, with baby coming after normal pokemon. I would assume this progression is hard coded and just checks if it is different from the other categories you have found. After this occurs, it just hands out the next badge in the progression. This is what I think would be most likely.

face515 commented 5 months ago

The link would be here.

Unlucky-Life commented 5 months ago

@face515 @omfgroflmfaol yea @omfgroflmfaol is right that was a hard encoded issue: image

Lul - but an easy fix

Unlucky-Life commented 5 months ago

@omfgroflmfaol easy fix, just replace the badges.json file in the addon_fileswith this one: https://github.com/Unlucky-Life/ankimon/blob/0a98291a8c4ba99b773dc58e53ad677598b4cd13/src/Ankimon/addon_files/badges.json